[
https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926574#comment-15926574
]
Chesnay Schepler edited comment on FLINK-6053 at 3/15/17 5:02 PM:
------------------------------------------------------------------
Actually we could change the AbstractReporter but it would be really hacky. We
would have to hava a Map that contains all gauges, add a separate map for
numberGauges, and another map for non-Number gauges. (All gauges for legacy
reporters, the other 2 maps for new reporters).
was (Author: zentol):
Actually we could change the AbstractReporter but it would be really hacky. We
would have to gauges Map that contains all gauges, add a separate map for
numberGauges, and another map for non-Number gauges. (All gauges for legacy
reporters, the other 2 maps for new reporters).
> Gauge<T> should only take subclasses of Number, rather than everything
> ----------------------------------------------------------------------
>
> Key: FLINK-6053
> URL: https://issues.apache.org/jira/browse/FLINK-6053
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.2.0
> Reporter: Bowen Li
> Fix For: 2.0.0
>
>
> Currently, Flink's Gauge is defined as
> ```java
> public interface Gauge<T> extends Metric {
> T getValue();
> }
> ```
> But it doesn't make sense to have Gauge take generic types other than Number.
> And it blocks I from finishing FLINK-6013, because I cannot assume Gauge is
> only about Number. So the class should be like
> ```java
> public interface Gauge<T extends Number> extends Metric {
> T getValue();
> }
> ```
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
