Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106601075
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object AggregateUtil {
(propPos._1, propPos._2)
}
- private def transformToAggregateFunctions(
--- End diff --
Using [flink] make this function can be accessed, that can work. But we
need think one thing: whether there function need be visit in the `flink` range
of package.
My suggestion is `private[table]` to apply other function in this class.
What other reviewer think about that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
