[
https://issues.apache.org/jira/browse/FLINK-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929702#comment-15929702
]
ASF GitHub Bot commented on FLINK-6097:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3560
[FLINK-6097][table] Guaranteed the order of the extracted field refer…
…ences as input order.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-6097]
Guaranteed the order of the extracted field references as input order.")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x ] Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6097-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3560.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3560
----
commit b2717309c1f7845c996a6acdb6ee197dacc5244e
Author: 金竹 <[email protected]>
Date: 2017-03-17T10:11:29Z
[FLINK-6097][table] Guaranteed the order of the extracted field references
as input order.
----
> Guaranteed the order of the extracted field references
> ------------------------------------------------------
>
> Key: FLINK-6097
> URL: https://issues.apache.org/jira/browse/FLINK-6097
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> The current `ProjectionTranslator # identifyFieldReferences` method uses the`
> Set` temporary save field, when the number of elements in the Set is less
> than 5, the Set takes the Se1, Se2, Se3, Se4 data structures. When the number
> of elements is greater than or equal to 5, the Set takes HashSet #
> HashTrieSet and which will cause the data to be out of order. although the
> out of order is also working, but I think the order is better than out of
> order. So I want to improve it,Orderly extraction field.i.e.Guaranteed the
> order of the extracted field references as input order.
> e.g.:
> Add the following elements in turn:
> {code}
> A, b, c, d, e
> Set (a)
> Class scala.collection.immutable.Set $ Set1
> Set (a, b)
> Class scala.collection.immutable.Set $ Set2
> Set (a, b, c)
> Class scala.collection.immutable.Set $ Set3
> Set (a, b, c, d)
> Class scala.collection.immutable.Set $ Set4
> Set (e, a, b, c, d) -> I want (a, b, c, d, e)
> Class scala.collection.immutable.HashSet $ HashTrieSet
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
