[
https://issues.apache.org/jira/browse/FLINK-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932959#comment-15932959
]
ASF GitHub Bot commented on FLINK-6132:
---------------------------------------
GitHub user gaqzcb opened a pull request:
https://github.com/apache/flink/pull/3576
[FLINK-6132]Remove redundant code in CliFrontend.java
Look at the switch case block in method parseParameters of CliFrontend.java.
```
// do action
switch (action) {
case ACTION_RUN:
return CliFrontend.this.run(params);
case ACTION_LIST:
return list(params);
case ACTION_INFO:
return info(params);
case ACTION_CANCEL:
return cancel(params);
case ACTION_STOP:
return stop(params);
case ACTION_SAVEPOINT:
return savepoint(params);
```
It's better to change the first case return clause
from：
`return CliFrontend.this.run(params);`
to：
`return run(params);`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhengcanbin/flink FLINK-6132
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3576.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3576
----
----
> Remove redundant code in CliFrontend.java
> -----------------------------------------
>
> Key: FLINK-6132
> URL: https://issues.apache.org/jira/browse/FLINK-6132
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Reporter: canbinzheng
> Priority: Minor
> Labels: starter
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Look at the switch case block in method parseParameters of CliFrontend.java.
> // do action
> switch (action) {
> case ACTION_RUN:
> return CliFrontend.this.run(params);
> case ACTION_LIST:
> return list(params);
> case ACTION_INFO:
> return info(params);
> case ACTION_CANCEL:
> return cancel(params);
> case ACTION_STOP:
> return stop(params);
> case ACTION_SAVEPOINT:
> return savepoint(params);
> It's better to change the first case return clause
> from：
> return CliFrontend.this.run(params);
> to：
> return run(params);
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
