[ 
https://issues.apache.org/jira/browse/FLINK-6134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933116#comment-15933116
 ] 

ASF GitHub Bot commented on FLINK-6134:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3578

    [FLINK-6134] Set UUID(0L, 0L) as default leader session id

    Before the default leader session id was null in the standalone case. 
However, in the ZooKeeper
    case null indicated that there was no active leader available. With this 
commit, the default
    leader id will be set to UUID(0L, 0L). This allows the uniform treatment of 
null denoting that
    there is no active leader across the standalone and the ZooKeeper case.
    
    With this change, the FlinkActors will now ignore all LeaderSessionMessages 
if the actor's
    leader id field is null. This indicates that the FlinkActor does not know 
the current leader.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink introduceDefaultLeaderId

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3578.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3578
    
----
commit 0fb0fe0a99de80379da2b758b06d333a7646c478
Author: Till Rohrmann <[email protected]>
Date:   2017-03-20T17:15:57Z

    [FLINK-6134] Set UUID(0L, 0L) as default leader session id
    
    Before the default leader session id was null in the standalone case. 
However, in the ZooKeeper
    case null indicated that there was no active leader available. With this 
commit, the default
    leader id will be set to UUID(0L, 0L). This allows the uniform treatment of 
null denoting that
    there is no active leader across the standalone and the ZooKeeper case.
    
    With this change, the FlinkActors will now ignore all LeaderSessionMessages 
if the actors's
    leader id field is null. This indicates that the FlinkActor does not know 
the current leader.

----


> Set UUID(0L, 0L) as default leader session id
> ---------------------------------------------
>
>                 Key: FLINK-6134
>                 URL: https://issues.apache.org/jira/browse/FLINK-6134
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> The leader election/retrieval services use the {{null}} value as the default 
> leader id in the standalone case but also as no active leader in the 
> ZooKeeper case. This is ambiguous and therefore I propose to change the 
> default leader id to {{UUID(0L, 0L)}}. Consequently, a {{null}} leader id 
> value can then indicate that there is no active leader available.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to