Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3477
Hi @dawidwys , I have 2 comments for this PR:
1) in the `findFinalStateAfterProceed()` in the `NFA` you should also check
the filter condition as you traverse the `PROCEED` edges towards the end.
2) In this PR the computation states are consuming, and the `endState` is a
"dummy" state.
Given this, in the `extractPatternMatches()` in the NFA, you do a
```
sharedBuffer.extractPatterns(
computationState.getPreviousState().getName(),
computationState.getEvent(),
computationState.getTimestamp(),
computationState.getVersion());
```
to extract the matched patterns.
This will work for patterns that terminate properly, as the `endState` now
is a "dummy" state and you do not want to present it. But if I understand
correctly, for timed out patterns, this means that the last state will not be
presented. Is this correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
