Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107060990
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -165,3 +165,31 @@ case class AmbiguousTableSourceConverterException(
def this(tableType: String) = this(tableType, null)
}
+
+/**
+ * Exception for operation on a nonexistent external catalog
+ *
+ * @param catalogName external catalog name
+ * @param cause
+ */
+case class ExternalCatalogNotExistException(
--- End diff --
hi, @twalthr , do you means that we could introduce two superclass, which
is AlreadyExistException and NotExistException, other exceptions are subclass
of these two exception class? IMO, there is no need to introduce a superclass,
because each exception represents a different unexpected situation that user
may cares, they may want to know whether database or table or something else
does not exist yet. what's your opinion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
