[ 
https://issues.apache.org/jira/browse/FLINK-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934155#comment-15934155
 ] 

ASF GitHub Bot commented on FLINK-6124:
---------------------------------------

Github user docete commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3579#discussion_r107081399
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
 ---
    @@ -916,6 +916,10 @@ object AggregateUtil {
                       new DecimalMinAggFunction
                     case BOOLEAN =>
                       new BooleanMinAggFunction
    +                case VARCHAR =>
    +                  new StringMinAggFunction
    +                case CHAR =>
    --- End diff --
    
    for 1 and 2, i will add max/minWithRetractAggFunction, ut, and integration 
test.
    for 3, we do support CHAR type in SQL, not in table api.


> support max/min aggregations for string type
> --------------------------------------------
>
>                 Key: FLINK-6124
>                 URL: https://issues.apache.org/jira/browse/FLINK-6124
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Zhenghua Gao
>            Assignee: Zhenghua Gao
>
> Recently when I port some query to Flink SQL, I found currently min/max 
> aggregations on string type is not supported and should be added.
> When min/max aggregations are used on string column, return min/max value by 
> lexicographically order.
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to