[
https://issues.apache.org/jira/browse/FLINK-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937952#comment-15937952
]
ASF GitHub Bot commented on FLINK-6129:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3573#discussion_r107615168
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -209,14 +223,29 @@ public void shutdown() {
reporters = null;
}
shutdownExecutor();
+
+ if (stopFuture != null) {
--- End diff --
if the MQS is started while a shutdown is in progress it might not be
cleaned up. What do you think about adding a lock here and in
startMetricQueryService?
> MetricRegistry does not stop query actor
> ----------------------------------------
>
> Key: FLINK-6129
> URL: https://issues.apache.org/jira/browse/FLINK-6129
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.3.0
>
>
> The {{MetricRegistry}} does not properly close the started query actor upon
> shutdown. This can be a resource leak.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
