Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3585#discussion_r107668755
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -99,28 +100,64 @@ class DataStreamOverAggregate(
.getFieldList
.get(overWindow.orderKeys.getFieldCollations.get(0).getFieldIndex)
.getValue
-
timeType match {
case _: ProcTimeType =>
- // both ROWS and RANGE clause with UNBOUNDED PRECEDING and CURRENT
ROW condition.
- if (overWindow.lowerBound.isUnbounded &&
- overWindow.upperBound.isCurrentRow) {
+ // proc-time OVER window
+ if (overWindow.lowerBound.isUnbounded &&
overWindow.upperBound.isCurrentRow) {
+ // non-bounded OVER window
createUnboundedAndCurrentRowProcessingTimeOverWindow(inputDS)
+ } else if (
+ overWindow.lowerBound.isPreceding &&
!overWindow.lowerBound.isUnbounded &&
+ overWindow.upperBound.isCurrentRow) {
+ // bounded OVER window
+ if (overWindow.isRows) {
+ // ROWS clause bounded OVER window
+ createRowsClauseBoundedAndCurrentRowOverWindow(inputDS)
+ } else {
+ // RANGE clause bounded OVER window
+ throw new TableException(
+ "RANGE clause bounded proc-time OVER window no supported
yet.")
+ }
} else {
throw new TableException(
- "OVER window only support ProcessingTime UNBOUNDED PRECEDING
and CURRENT ROW " +
- "condition.")
+ "proc-time OVER window only support CURRENT ROW condition.")
}
case _: RowTimeType =>
- throw new TableException("OVER Window of the EventTime type is not
currently supported.")
+ // row-time OVER window
+ if (overWindow.lowerBound.isUnbounded &&
overWindow.upperBound.isCurrentRow) {
+ // non-bounded OVER window
+ if (overWindow.isRows) {
--- End diff --
I don't think we need the rows / range distinction for unbounded-currentRow
windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
