[ 
https://issues.apache.org/jira/browse/FLINK-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938843#comment-15938843
 ] 

ASF GitHub Bot commented on FLINK-6043:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3583#discussion_r107732859
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java
 ---
    @@ -0,0 +1,55 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.executiongraph;
    +
    +/**
    + * Simple container to hold an exception and the corresponding timestamp.
    + */
    +class ErrorInfo {
    +   private volatile Throwable exception;
    +   private volatile long timestamp;
    +
    +   /**
    +    * Sets the exception and corresponding timestamp.
    +    * 
    +    * @param exception Exception to set
    +    * @param timestamp Timestamp when exception occurred
    +    */
    +   void setExceptionAndTimestamp(Throwable exception, long timestamp) {
    +           this.exception = exception;
    +           this.timestamp = timestamp;
    --- End diff --
    
    What if we don't allow the user to specify a timestamp but automatically 
call `System.currentTimeMillis`? That way we wouldn't have to wire the 
`causeTimestamp` through all the different functions in the `ExecutionGraph`.


> Display time when exceptions/root cause of failure happened
> -----------------------------------------------------------
>
>                 Key: FLINK-6043
>                 URL: https://issues.apache.org/jira/browse/FLINK-6043
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>    Affects Versions: 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Chesnay Schepler
>            Priority: Minor
>
> In order to better understand the behaviour of Flink jobs, it would be nice 
> to add timestamp information to exception causing the job to restart or to 
> fail. This information could then be displayed in the web UI making it easier 
> for the user to understand what happened when.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to