[ 
https://issues.apache.org/jira/browse/FLINK-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939365#comment-15939365
 ] 

Fabian Hueske commented on FLINK-5570:
--------------------------------------

Thanks for the feedback [~wheat9]. 

I think we are fine at the moment, but could update the {{isRegistered()}} and 
{{getRowType()}} methods to also take an {{Array[String]}} parameter.
At the moment, they {{isRegistered()}} is only called from methods that manage 
the top-level tables (not those in the catalog). {{getRowType()}} was only 
called from {{scan()}} and is now unused so it could be removed.

> Support register external catalog to table environment
> ------------------------------------------------------
>
>                 Key: FLINK-5570
>                 URL: https://issues.apache.org/jira/browse/FLINK-5570
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kurt Young
>            Assignee: jingzhang
>
> This issue aims to support register one or more {{ExternalCatalog}} (which is 
> referred in https://issues.apache.org/jira/browse/FLINK-5568) to 
> {{TableEnvironment}}. After registration, SQL and TableAPI queries could 
> access to tables in the external catalogs without register those tables one 
> by one to {{TableEnvironment}} beforehand.
> We plan to add two APIs in {{TableEnvironment}}:
> 1. register externalCatalog
> {code}
> def registerExternalCatalog(name: String, externalCatalog: ExternalCatalog): 
> Unit
> {code}
> 2. scan a table from registered catalog and returns the resulting {{Table}},  
> the API is very useful in TableAPI queries.
> {code}
> def scan(catalogName: String, tableIdentifier: TableIdentifier): Table
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to