[
https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941619#comment-15941619
]
ASF GitHub Bot commented on FLINK-4562:
---------------------------------------
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
> I agree with @wuchong , that we should follow the example of Gelly and
add the flink-table-examples JAR file to the opt folder.
@fhueske Thanks for your review.
IMO, directory style below is reasonable:
* `examples` directory only contain example jars
* `opt` directory only contain optional library jars
* `lib` directory only contain library jar that must be load in runtime
The `opt` directory is noisy, that contains lib jar and example jar:
```
flink-cep-scala_2.11-1.3.0.jar
flink-gelly_2.11-1.3.0.jar
flink-metrics-statsd-1.3.0.jar
flink-cep_2.11-1.3.0.jar
flink-metrics-dropwizard-1.3.0.jar
flink-ml_2.11-1.3.0.jar
flink-gelly-examples_2.11-1.3.0.jar
flink-metrics-ganglia-1.3.0.jar
flink-gelly-scala_2.11-1.3.0.jar
flink-metrics-graphite-1.3.0.jar
```
> table examples make an divided module in flink-examples
> -------------------------------------------------------
>
> Key: FLINK-4562
> URL: https://issues.apache.org/jira/browse/FLINK-4562
> Project: Flink
> Issue Type: Improvement
> Components: Examples, Table API & SQL
> Reporter: shijinkui
> Assignee: shijinkui
> Fix For: 1.2.1
>
>
> example code should't packaged in table module.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
