[ 
https://issues.apache.org/jira/browse/FLINK-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942433#comment-15942433
 ] 

ASF GitHub Bot commented on FLINK-5911:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3433#discussion_r108069363
  
    --- Diff: 
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Parameter.java
 ---
    @@ -0,0 +1,55 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.graph.drivers.parameter;
    +
    +import org.apache.flink.api.java.utils.ParameterTool;
    +
    +/**
    + * Encapsulates the usage and configuration of a command-line parameter.
    + *
    + * @param <T> parameter value type
    + */
    +public interface Parameter<T> {
    +
    +   /**
    +    * An informal usage string. Parameter names are prefixed with "--".
    +    *
    +    * Optional parameters are enclosed by "[" and "]".
    +    *
    +    * Generic values are represented by all-caps with specific values 
enclosed
    +    * by "&lt;" and "&gt;".
    +    *
    +    * @return command-line usage string
    +    */
    +   String getParameterization();
    --- End diff --
    
    That does sound better. Will refactor.


> Command-line parameters
> -----------------------
>
>                 Key: FLINK-5911
>                 URL: https://issues.apache.org/jira/browse/FLINK-5911
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Gelly
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.3.0
>
>
> Create interface for parsing command-line parameters using {{ParameterTool}} 
> and generic implementations for boolean, long, double, string, choice.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to