[
https://issues.apache.org/jira/browse/FLINK-6192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943638#comment-15943638
]
ASF GitHub Bot commented on FLINK-6192:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3617
Thanks for your contribution @WangTaoTheTonic. Your observation of the
problem is correct.
Actually I'm also working on refactoring the usage of the ZooKeeper based
leader election and retrieval services. The respective issue is
[FLINK-6078](https://issues.apache.org/jira/browse/FLINK-6078). The problem is
not only creating a single curator framework but also preventing the leader
retrieval and election services from closing it when shutting down the
respective service. Moreover, we should use the newly introduced
`HighAvailabilityServices` as a factory for the services. That way the service
instantiation can be controlled from a single place.
Given that, I think that we can close this PR. I will open a PR for
FLINK-6078 in the next days. Feel free to review it.
> reuse zookeeer client created by CuratorFramework
> -------------------------------------------------
>
> Key: FLINK-6192
> URL: https://issues.apache.org/jira/browse/FLINK-6192
> Project: Flink
> Issue Type: Sub-task
> Components: JobManager, YARN
> Reporter: Tao Wang
> Assignee: Tao Wang
>
> Now in yarn mode, there're three places using zookeeper client(web monitor,
> jobmanager and resourcemanager) in ApplicationMaster/JobManager, while
> there're two in TaskManager. They create new one zookeeper client when they
> need them.
> I believe there're more other places do the same thing, but in one JVM, one
> CuratorFramework is enough for connections to one zookeeper client, so we
> need a singleton to reuse them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
