[
https://issues.apache.org/jira/browse/FLINK-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945108#comment-15945108
]
ASF GitHub Bot commented on FLINK-6043:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3583#discussion_r108414337
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
---
@@ -632,8 +632,8 @@ void executionFailed(Throwable t) {
/**
* Simply forward this notification. This is for logs and event
archivers.
*/
- void notifyStateTransition(ExecutionAttemptID executionId,
ExecutionState newState, Throwable error) {
- getExecutionGraph().notifyExecutionChange(getJobvertexId(),
subTaskIndex, executionId, newState, error);
+ void notifyStateTransition(ExecutionAttemptID executionId,
ExecutionState newState, Throwable error, long errorTimestamp) {
--- End diff --
Technically, yes, it is the TS when the Execution went into the state
FAILED.
Since we can't use the TM timestamp this seemed like the most appropriate
one to take. The only other option would be to take a TS when the
UpdateTaskExecutionState message hits the JM; at that point though we are
already at a point where the timestamp isn't particularly accurate, so by using
the FAILED timestamp we aren't really losing accuracy, but affect fewer methods.
> Display time when exceptions/root cause of failure happened
> -----------------------------------------------------------
>
> Key: FLINK-6043
> URL: https://issues.apache.org/jira/browse/FLINK-6043
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Priority: Minor
>
> In order to better understand the behaviour of Flink jobs, it would be nice
> to add timestamp information to exception causing the job to restart or to
> fail. This information could then be displayed in the web UI making it easier
> for the user to understand what happened when.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
