[
https://issues.apache.org/jira/browse/FLINK-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945559#comment-15945559
]
ASF GitHub Bot commented on FLINK-6183:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3610#discussion_r108478998
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -80,8 +80,17 @@ public TaskMetricGroup addTask(
taskName,
subtaskIndex,
attemptNumber);
- tasks.put(executionAttemptID, task);
- return task;
+ TaskMetricGroup prior =
tasks.put(executionAttemptID, task);
+ if (prior == null) {
+ return task;
--- End diff --
Can you avoid adding `closeLocally()` by simply doing a "contains()" check
before creating the group?
> TaskMetricGroup may not be cleanup when Task.run() is never called or exits
> early
> ---------------------------------------------------------------------------------
>
> Key: FLINK-6183
> URL: https://issues.apache.org/jira/browse/FLINK-6183
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
>
> The TaskMetricGroup is created when a Task is created. It is cleaned up at
> the end of Task.run() in the finally block. If however run() is never called
> due some failure between the creation and the call to run the metric group is
> never closed. This also means that the JobMetricGroup is never closed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
