Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/3607
  
    Hi, @rtudoran  When open a PR. we should keep our commits based on the 
latest master branch, so that the PR. only contains the change for this issue 
and will be clearly for other's review.I had check your `Commits` list and 
changes. There were something wrong when you rebase the code. When I rebase 
code, I usually use git command as follow: 
    ```
      git checkout myBranch
      git remote add upstream https://github.com/apache/flink.git
      git fetch upstream
      git rebase upstream/master
    ```
    Everyone's local environment is different, the above operation is for 
reference only.
    
    Best,
    SunJincheng


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to