Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3589#discussion_r108786995
  
    --- Diff: docs/dev/table_api.md ---
    @@ -1274,11 +1274,159 @@ A session window is defined by using the `Session` 
class as follows:
     
     #### Limitations
     
    -Currently the following features are not supported yet:
    +The following table summarizes available windows:
     
    -- Row-count windows on event-time
    -- Non-grouped session windows on batch tables
    -- Sliding windows on batch tables
    +<table class="table table-bordered">
    +  <thead>
    +    <tr>
    +      <th class="text-left" style="width: 15%">Batch or streaming</th>
    +      <th class="text-left" style="width: 15%">Table API</th>
    +      <th class="text-left" style="width: 15%">Time</th>
    +      <th class="text-left" style="width: 15%">Time or count interval</th>
    +      <th class="text-left" style="width: 15%">Grouped or ungrouped</th>
    +      <th class="text-left" style="width: 15%">Supported?</th>
    +    </tr>
    +  </thead>
    +
    +  <tbody>
    +    <tr>
    +      <td>Batch</td>
    +      <td>Tumble</td>
    +      <td>Event-time</td>
    +      <td>Count</td>
    +      <td>Grouped</td>
    +      <td>Yes</td>
    +    </tr>
    +    <tr>
    +      <td>Batch</td>
    +      <td>Tumble</td>
    +      <td>Event-time</td>
    +      <td>Count</td>
    +      <td>Ungrouped</td>
    +      <td>No</td>
    +    </tr>
    +    <tr>
    +      <td>Batch</td>
    +      <td>Tumble</td>
    +      <td>Event-time</td>
    +      <td>Time</td>
    +      <td>Both</td>
    +      <td>Yes</td>
    +    </tr>
    +    <tr>
    +      <td>Batch</td>
    +      <td>Tumble</td>
    +      <td>Processing-time</td>
    --- End diff --
    
    I think we should remove the processing-time batch combination. Listing it 
in the table makes the API look incomplete even though this combination does 
not make sense and will never be supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to