[
https://issues.apache.org/jira/browse/FLINK-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948671#comment-15948671
]
ASF GitHub Bot commented on FLINK-6210:
---------------------------------------
Github user shixiaogang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3652#discussion_r108868469
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/benchmark/ListViaMergeSpeedMiniBenchmark.java
---
@@ -50,55 +50,59 @@ public static void main(String[] args) throws Exception
{
final RocksDB rocksDB = RocksDB.open(options,
rocksDir.getAbsolutePath());
- final String key = "key";
- final String value =
"abcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ7890654321";
+ try {
--- End diff --
I think it's better to use try-with-resources here.
> RocksDB instance should be closed in ListViaMergeSpeedMiniBenchmark
> -------------------------------------------------------------------
>
> Key: FLINK-6210
> URL: https://issues.apache.org/jira/browse/FLINK-6210
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Ted Yu
> Assignee: fang yong
> Priority: Minor
>
> rocksDB instance should be closed upon returning from main().
> ListViaRangeSpeedMiniBenchmark has similar issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
