[
https://issues.apache.org/jira/browse/FLINK-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948782#comment-15948782
]
ASF GitHub Bot commented on FLINK-5625:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3651#discussion_r108886451
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@ -216,14 +217,73 @@ public void
testUnixTimestampInValidateOptionDatePropertyForInitialTimestampInCo
testConfig.setProperty(ConsumerConfigConstants.STREAM_INITIAL_POSITION,
"AT_TIMESTAMP");
testConfig.setProperty(ConsumerConfigConstants.STREAM_INITIAL_TIMESTAMP,
unixTimestamp);
- KinesisConfigUtil.validateConsumerConfiguration(testConfig);
+ try {
+
KinesisConfigUtil.validateConsumerConfiguration(testConfig);
- try{
double value = Double.parseDouble(unixTimestamp);
if (value < 0) {
throw new NumberFormatException();
}
--- End diff --
Why do we need this:
```
double value = Double.parseDouble(unixTimestamp);
if (value < 0) {
throw new NumberFormatException();
}
```
here?
> Let Date format for timestamp-based start position in Kinesis consumer be
> configurable.
> ---------------------------------------------------------------------------------------
>
> Key: FLINK-5625
> URL: https://issues.apache.org/jira/browse/FLINK-5625
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Wei-Che Wei
>
> Currently, the Kinesis consumer's Date format for timestamp-based start
> positions is fixed. It'll be nice to make this format configurable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
