Github user tony810430 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3651#discussion_r108888462
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
 ---
    @@ -216,14 +217,73 @@ public void 
testUnixTimestampInValidateOptionDatePropertyForInitialTimestampInCo
                
testConfig.setProperty(ConsumerConfigConstants.STREAM_INITIAL_POSITION, 
"AT_TIMESTAMP");
                
testConfig.setProperty(ConsumerConfigConstants.STREAM_INITIAL_TIMESTAMP, 
unixTimestamp);
     
    -           KinesisConfigUtil.validateConsumerConfiguration(testConfig);
    +           try {
    +                   
KinesisConfigUtil.validateConsumerConfiguration(testConfig);
     
    -           try{
                        double value = Double.parseDouble(unixTimestamp);
                        if (value < 0) {
                                throw new NumberFormatException();
                        }
    --- End diff --
    
    Because I want to force the value be positive. Is it okey to let it be 
negative?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to