Github user fhueske commented on the pull request:
https://github.com/apache/flink/commit/d4665a00a4262f89b166895f73a54daab2f25e1c#commitcomment-21555986
In
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala:
In
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
on line 203:
Hi @rtudoran,
this PR added support for event-time OVER RANGE windows. Stefano and you
are working on processing time OVER RANGE/ROWS windows which require a
different implementation, no?
I assume you are upset because the function was changed to support the row
and range case. However, in the function the actual code for this part is still
missing. This is where your code would go.
I know working concurrently with others on the same code can mean a lot of
rebasing and change merging. However, we merge PRs once they are ready to be
merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
