[
https://issues.apache.org/jira/browse/FLINK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953306#comment-15953306
]
ASF GitHub Bot commented on FLINK-2720:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3615#discussion_r109391296
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -115,14 +126,16 @@ public ReducedMetric registerMetric(final String
name, final IReducer combiner,
}
/**
- * Not supported by Flink.
- *
- * @throws UnsupportedOperationException
- * at every invocation
+ * @return - null when storm metric not supported by flink
*/
@Override
public <T extends IMetric> T registerMetric(final String name, final T
metric, final int timeBucketSizeInSecs) {
- throw new UnsupportedOperationException("Metrics are not
supported by Flink");
+ IMetricAdapter<T> adapter =
MetricConvert.convertFlinkAdapter(name, metric, context);
+ if (adapter == null) {
+ LOG.info("Metric not supportted by Flink");
--- End diff --
typo: supportted -> supported
> Add Storm-CountMetric in flink-stormcompatibility
> -------------------------------------------------
>
> Key: FLINK-2720
> URL: https://issues.apache.org/jira/browse/FLINK-2720
> Project: Flink
> Issue Type: New Feature
> Components: Storm Compatibility
> Reporter: Huang Wei
> Assignee: Matthias J. Sax
> Fix For: 1.0.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the CountMetric for the first step of storm metrics:
> 1.Do a wrapper FlinkCountMetric for CountMetric
> 2.push the RuntimeContext in FlinkTopologyContext to use `addAccumulator`
> method for registering the metric.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
