Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3615#discussion_r109391296
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -115,14 +126,16 @@ public ReducedMetric registerMetric(final String
name, final IReducer combiner,
}
/**
- * Not supported by Flink.
- *
- * @throws UnsupportedOperationException
- * at every invocation
+ * @return - null when storm metric not supported by flink
*/
@Override
public <T extends IMetric> T registerMetric(final String name, final T
metric, final int timeBucketSizeInSecs) {
- throw new UnsupportedOperationException("Metrics are not
supported by Flink");
+ IMetricAdapter<T> adapter =
MetricConvert.convertFlinkAdapter(name, metric, context);
+ if (adapter == null) {
+ LOG.info("Metric not supportted by Flink");
--- End diff --
typo: supportted -> supported
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
