[
https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953351#comment-15953351
]
ASF GitHub Bot commented on FLINK-6149:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r109253071
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -228,15 +229,24 @@ abstract class BatchTableEnvironment(
}
// 3. optimize the logical Flink plan
- val optRuleSet = getOptRuleSet
- val flinkOutputProps =
relNode.getTraitSet.replace(DataSetConvention.INSTANCE).simplify()
- val optimizedPlan = if (optRuleSet.iterator().hasNext) {
- runVolcanoPlanner(optRuleSet, normalizedPlan, flinkOutputProps)
+ val logicalOptRuleSet = getLogicalOptRuleSet
+ val logicalOutputProps =
relNode.getTraitSet.replace(FlinkConventions.LOGICAL).simplify()
+ val logicalPlan = if (logicalOptRuleSet.iterator().hasNext) {
+ runVolcanoPlanner(logicalOptRuleSet, normalizedPlan,
logicalOutputProps)
--- End diff --
Isn't the plan to use the rule-based `HepPlanner` instead of the
`VolcanoPlanner` for logical optimization or should switching be a follow-up
step?
> add additional flink logical relation nodes
> -------------------------------------------
>
> Key: FLINK-6149
> URL: https://issues.apache.org/jira/browse/FLINK-6149
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Kurt Young
> Assignee: Kurt Young
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
