[
https://issues.apache.org/jira/browse/FLINK-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958360#comment-15958360
]
ASF GitHub Bot commented on FLINK-6261:
---------------------------------------
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3675
Thanks for the PR! It looks good to me overall. One problem is that
`dataSet.LogicalWindowAggregateRule` has duplicated quite a bit of code in the
`dataStream.LogicalWindowAggregateRule`.
Maybe it makes sense to refactor some of the code into a common class, so
that we can follow the same pattern for the implementation of the WindowStart /
WindowEnd functions?
> Add support for TUMBLE, HOP, SESSION to batch SQL
> -------------------------------------------------
>
> Key: FLINK-6261
> URL: https://issues.apache.org/jira/browse/FLINK-6261
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
>
> Add support for the TUMBLE, HOP, SESSION keywords for batch SQL.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
