[
https://issues.apache.org/jira/browse/FLINK-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958693#comment-15958693
]
ASF GitHub Bot commented on FLINK-6079:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3685
Thanks for the PR! I think #3476 solves this indirectly also, but it would
make sense to fix the issue with this PR first as #3476 still needs some time
and massaging.
LGTM, definitely an improvement to guard against subclass implementations.
+1.
> Ineffective null check in FlinkKafkaConsumerBase#open()
> -------------------------------------------------------
>
> Key: FLINK-6079
> URL: https://issues.apache.org/jira/browse/FLINK-6079
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector
> Reporter: Ted Yu
> Assignee: Chesnay Schepler
> Priority: Minor
>
> Here is related code:
> {code}
> List<KafkaTopicPartition> kafkaTopicPartitions =
> getKafkaPartitions(topics);
> subscribedPartitionsToStartOffsets = new
> HashMap<>(kafkaTopicPartitions.size());
> if (kafkaTopicPartitions != null) {
> {code}
> Prior to the null check, kafkaTopicPartitions is already dereferenced.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
