Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/3686#discussion_r110337693
--- Diff:
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -162,11 +162,11 @@ public void
testJDBCInputFormatWithParallelismAndNumericColumnSplitting() throws
if (next == null) {
break;
}
- if(next.getField(0)!=null) {
Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
- if(next.getField(1)!=null) {
Assert.assertEquals("Field 1 should be String", String.class,
next.getField(1).getClass());}
- if(next.getField(2)!=null) {
Assert.assertEquals("Field 2 should be String", String.class,
next.getField(2).getClass());}
- if(next.getField(3)!=null) {
Assert.assertEquals("Field 3 should be float", Double.class,
next.getField(3).getClass());}
- if(next.getField(4)!=null) {
Assert.assertEquals("Field 4 should be int", Integer.class,
next.getField(4).getClass());}
+ if (next.getField(0) != null) {
Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
--- End diff --
I didn't know that Flink introduces checkstyle at compile time...is there
any official Eclipse formatter somewhere I can use to verify the code at
development time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
