[ 
https://issues.apache.org/jira/browse/FLINK-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966526#comment-15966526
 ] 

ASF GitHub Bot commented on FLINK-6090:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3696#discussion_r110376285
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamCorrelate.scala
 ---
    @@ -36,14 +36,14 @@ import org.apache.flink.types.Row
     class DataStreamCorrelate(
         cluster: RelOptCluster,
         traitSet: RelTraitSet,
    -    inputNode: RelNode,
    --- End diff --
    
    Please revert these changes. We try to avoid reformatting changes because 
they make PRs harder to review. 


> Add RetractionRule at the stage of decoration
> ---------------------------------------------
>
>                 Key: FLINK-6090
>                 URL: https://issues.apache.org/jira/browse/FLINK-6090
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Hequn Cheng
>
> Implement optimizer for retraction:
>   1.Add RetractionRule at the stage of decoration,which can derive the 
> replace table/append table, NeedRetraction property.
>   2.Match the NeedRetraction and replace table, mark the accumulating mode
>  
> When this task is finished, we can turn on retraction for different operators 
> according to accumulating mode.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to