[
https://issues.apache.org/jira/browse/FLINK-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969983#comment-15969983
]
ASF GitHub Bot commented on FLINK-6143:
---------------------------------------
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3710#discussion_r111666373
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -59,7 +59,7 @@
private final Object lock = new Object();
/** The mini cluster on which to execute the local programs */
- private LocalFlinkMiniCluster flink;
+ private volatile LocalFlinkMiniCluster flink;
--- End diff --
Thanks for telling me so useful message. Appreciate it.
> Unprotected access to this.flink in LocalExecutor#endSession()
> --------------------------------------------------------------
>
> Key: FLINK-6143
> URL: https://issues.apache.org/jira/browse/FLINK-6143
> Project: Flink
> Issue Type: Bug
> Components: Client
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> public void endSession(JobID jobID) throws Exception {
> LocalFlinkMiniCluster flink = this.flink;
> if (flink != null) {
> {code}
> The flink field is not declared volatile and access to this.flink doesn't
> hold the LocalExecutor.lock
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
