[
https://issues.apache.org/jira/browse/FLINK-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971996#comment-15971996
]
ASF GitHub Bot commented on FLINK-5943:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3730
[FLINK-5943] [YARN] Fix unprotected access to haServices in YarnFlink…
…ApplicationMasterRunner#shutdown().
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-5943
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3730.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3730
----
commit f31052dbe8a7b8150504757c15b3e731cc6f87c2
Author: zhangminglei <[email protected]>
Date: 2017-04-18T02:00:09Z
[FLINK-5943] [YARN] Fix unprotected access to haServices in
YarnFlinkApplicationMasterRunner#shutdown().
----
> Unprotected access to haServices in
> YarnFlinkApplicationMasterRunner#shutdown()
> -------------------------------------------------------------------------------
>
> Key: FLINK-5943
> URL: https://issues.apache.org/jira/browse/FLINK-5943
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> protected void shutdown(ApplicationStatus status, String msg) {
> // Need to clear the job state in the HA services before shutdown
> try {
> haServices.getRunningJobsRegistry().clearJob(jobGraph.getJobID());
> }
> {code}
> The access to haServices is without lock protection.
> haServices may have been closed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
