Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3735#discussion_r111984555
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala
---
@@ -97,12 +94,7 @@ class DataSetAggFunction(
}
// set agg results to output
- i = 0
- while (i < aggOutMapping.length) {
- val (out, in) = aggOutMapping(i)
- output.setField(out, aggregates(in).getValue(accumulators(in)))
- i += 1
- }
+ function.setAggregationResults(accumulators, output)
// set grouping set flags to output
if (intermediateGKeys.isDefined) {
--- End diff --
I think this should eventually be integrated with `setForwardFields()` as
well.
For now, we might leave it as it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
