[
https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973293#comment-15973293
]
ASF GitHub Bot commented on FLINK-1984:
---------------------------------------
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3586#discussion_r112036109
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -166,7 +191,36 @@ public static MesosTaskManagerParameters
create(Configuration flinkConfig) {
cpus,
containerType,
Option.apply(imageName),
- containeredParameters);
+ containeredParameters,
+ constraints);
+ }
+
+ private static List<ConstraintEvaluator> parseConstraints(String
mesosConstraints) {
+ List<ConstraintEvaluator> constraints = new ArrayList<>();
+
+ if (mesosConstraints != null) {
+ for (String constraint :
Arrays.asList(mesosConstraints.split(","))) {
+ if (constraint.isEmpty()) {
+ continue;
+ }
+ final List<String> constraintList =
Arrays.asList(constraint.split(":"));
+ if (constraintList.size() != 2) {
+ continue;
+ }
+ addConstraint(constraints, constraintList);
+ }
+ }
+
+ return constraints;
+ }
+
+ private static void addConstraint(List<ConstraintEvaluator>
constraints, final List<String> constraintList) {
--- End diff --
Would you mind replacing `constraintList` with a pair of arguments for the
attr name and value, and rename the `addConstraint` method to
`addHostAttrValueConstraint`?
> Integrate Flink with Apache Mesos
> ---------------------------------
>
> Key: FLINK-1984
> URL: https://issues.apache.org/jira/browse/FLINK-1984
> Project: Flink
> Issue Type: New Feature
> Components: Cluster Management, Mesos
> Reporter: Robert Metzger
> Assignee: Eron Wright
> Priority: Minor
> Fix For: 1.2.0
>
> Attachments: 251.patch
>
>
> There are some users asking for an integration of Flink into Mesos.
> -There also is a pending pull request for adding Mesos support for Flink-:
> https://github.com/apache/flink/pull/251
> Update (May '16): a new effort is now underway, building on the recent
> ResourceManager work.
> Update (Oct '16): the core functionality is in the master branch. New
> sub-tasks track remaining work for a first release.
> Design document: ([google
> doc|https://docs.google.com/document/d/1WItafBmGbjlaBbP8Of5PAFOH9GUJQxf5S4hjEuPchuU/edit?usp=sharing])
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
