[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974213#comment-15974213
]
Tzu-Li (Gordon) Tai edited comment on FLINK-6311 at 4/19/17 7:18 AM:
---------------------------------------------------------------------
I think we can just do:
{code}
if (mainThread != null) {
mainThread.interrupt();
}
{code}
and likewise for the executor.
The reason is that there can be cases that the consumer is closed before these
fields reference actual values (they are assigned after run() starts, but there
is no guarantee when close() is called on the consumer). So, we should just do
null checks to safe guard against such conditions.
was (Author: tzulitai):
I think we can just do:
{code}
if (mainThread != null) {
mainThread.interrupt();
}
{code}
and likewise for the executor.
The reason is that there can be cases that the consumer is closed before this
fields reference actual values (they are assigned after run() starts, but there
is no guarantee when close() is called on the consumer). So, we should just do
null checks to safe guard against such conditions.
> NPE in FlinkKinesisConsumer if source was closed before run
> -----------------------------------------------------------
>
> Key: FLINK-6311
> URL: https://issues.apache.org/jira/browse/FLINK-6311
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: mingleizhang
>
> This was reported by an user:
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flink-errors-out-and-job-fails-IOException-from-CollectSink-open-td12606.html
> The {{shutdownFetcher}} method of {{KinesisDataFetcher}} is not protected
> against the condition when the source was closed before it started running.
> Both {{mainThread}} and {{shardConsumersExecutor}} should have null checks.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
