[
https://issues.apache.org/jira/browse/FLINK-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053123#comment-14053123
]
ASF GitHub Bot commented on FLINK-925:
--------------------------------------
GitHub user tobwiens opened a pull request:
https://github.com/apache/incubator-flink/pull/58
[FLINK-925] Support KeySelector function returning Tuples
Tuple types can be returned by the KeySelector. Enabling tuple types to be
used as KEYs for grouping.
Added test cases using TupleComparatorTestBase. Testing
Tuple3<Tuple2,Tuple2,Tuple2>.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tobwiens/incubator-flink FLINK-925-FIX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 39fc1928665a28dbc18b7834f6527ca84a3458ec
Author: TobiasWiens <[email protected]>
Date: 2014-07-06T13:53:14Z
[FLINK-925] Support KeySelector function returning Tuples
----
> Support KeySelector function returning Tuples
> ---------------------------------------------
>
> Key: FLINK-925
> URL: https://issues.apache.org/jira/browse/FLINK-925
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 0.6-incubating
> Reporter: Fabian Hueske
> Assignee: Tobias
> Priority: Minor
> Labels: starter
>
> KeySelector functions are used to extract keys on which DataSets can be
> grouped or joined.
> Currently, the keys types returned by KeySelector function are restricted to
> be comparable. However, Flinks Tuple data types are not comparable (because
> this depends on the types of its fields) which makes grouping and joining on
> composite keys difficult.
> We should change the signature of the groupBy(), join(), and coGroup()
> methods to allow also non-comparable keys as return types of a KeySelector
> function.
> Instead we will check at optimization time whether the returned type is
> comparable (which is true for tuples if all elements are comparable).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
