[
https://issues.apache.org/jira/browse/FLINK-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053435#comment-14053435
]
ASF GitHub Bot commented on FLINK-827:
--------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/45#issuecomment-48152087
Looks good, but one last thing. Can you extract the parameter handling and
usage descriptions to a separate private method as done in the other examples.
The purpose is to reduce the boilerplate code in the main method such that it
only contains code which is relevant for the example.
After that you can squash the commits and push with force to your PR
branch. The PR will be automatically updated. Please do also a rebase to the
latest master.
Thanks
> Add Java example program with KeySelectors
> ------------------------------------------
>
> Key: FLINK-827
> URL: https://issues.apache.org/jira/browse/FLINK-827
> Project: Flink
> Issue Type: Bug
> Reporter: GitHub Import
> Assignee: Tobias
> Labels: github-import
> Fix For: pre-apache
>
>
> We need a Java example program that shows the use of `KeySelector` functions.
> Alternatively we could modify an existing program to do this.
> The new example program should follow the general layout of the other example
> programs, i.e., run without parameters on default data, have the same code
> structure, etc.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/827
> Created by: [fhueske|https://github.com/fhueske]
> Labels: documentation, java api,
> Milestone: Release 0.6 (unplanned)
> Created at: Sat May 17 12:45:24 CEST 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.2#6252)
