[
https://issues.apache.org/jira/browse/FLINK-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054807#comment-14054807
]
Stephan Ewen commented on FLINK-1007:
-------------------------------------
Just a comment from my side: For Java sources, we do not force breaking at a
certain line length.
I personally use 120 char lines, which helps me read the code on modern
displays (it appears more "straight" to me). For exception messages, I often
break even later, because I find it does not hurt to not see the entire message
on the screen at once.
> Clean up and refactor on Scala and Java code
> --------------------------------------------
>
> Key: FLINK-1007
> URL: https://issues.apache.org/jira/browse/FLINK-1007
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
>
> First cleanup attempt, mostly on Scala code, to follow guidelines from
> http://docs.scala-lang.org/style:
> 1. Remove return statement from Scala code where it is not necessary (end of
> method definition)
> 2. Remove extra semicolon (;) from Scala and Java code
> 3. First drop to abide to 100 chars per line for Scala code.
> Will send another PR for other files as I have encountered.
> 4. Remove parentheses for empty argument methods that do not have side effect
> (see
> http://www.artima.com/pins1ed/composition-and-inheritance.html#i1343251059-1)
> 5. Remove unused import statements in Scala code as I have encountered them.
> This is first drop to refactor and cleanup Scala code to see comment/
> response from community.
> More PRs for follow up code will come.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
