Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/111#discussion_r17102779
--- Diff: DEPENDENCIES ---
@@ -43,6 +42,8 @@ The Apache Flink project depends on and/or bundles the
following components
under the Eclipse Public License (v 1.0)
- JUnit (http://junit.org/)
+ - logback (http://logback.qos.ch)
+ Copyright (C) 1999-2012, QOS.ch. All rights reserved.
--- End diff --
Nice that you didn't forget to update this :+1:
I'm not sure if the Copyright line is necessary, because you have it in the
lower section. And for the name, I think we should have it as LOGBack.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---