[
https://issues.apache.org/jira/browse/FLINK-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125468#comment-14125468
]
Jonathan Hasenburg commented on FLINK-1055:
-------------------------------------------
Hi Robert,
what exactly do you mean with webfrontend? Do you refer to the Webclient (the
thing with the graphs)? If so I do not things that this is necessary anymore
because I recreated the JSON generation. They are no longer generated by
strings. That way you get a compilation error or your IDE warns you if you
break the syntax (see https://issues.apache.org/jira/browse/FLINK-1082).
Right now there is no testing regarding the structure of the JSON for the
graphs. But I do not think that this would be helpful because if you change
something on the generation you will change the view, too. Otherwise this would
not make sense... . If you did so there are two possibilities:
1. You see something
2. You don't
To maintain working tests for this would not help but cause extra work. In
addition most of the parameters for the json are optional -> if they are
missing it does not cause problems, the graph has less information, that's all.
That's why a test would not make much sense here.
> JM Webfrontend needs unit tests
> -------------------------------
>
> Key: FLINK-1055
> URL: https://issues.apache.org/jira/browse/FLINK-1055
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: Robert Metzger
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are currently no tests that validate if the generated JSON is valid (or
> if the frontend is actually able to generate the JSONs).
> We had too many bugs in the past related to the web frontend. In addition to
> that, it is a lot of work to manually test it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
