Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/94#issuecomment-55935923
Looks good, this is almost ready to merge. Two minor comments:
- The `configure()` method of the output format is invoked also on the
master. The open Method would therefor be the better place for the RMI
initialization, in my opinion, it would help efficiency.
- Also, a naming convention: We don't start interfaces with `I`. For the
sake of a homogeneous code style, I would ask you to follow a similar style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
