[
https://issues.apache.org/jira/browse/FLINK-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154625#comment-14154625
]
ASF GitHub Bot commented on FLINK-12:
-------------------------------------
GitHub user StephanEwen opened a pull request:
https://github.com/apache/incubator-flink/pull/135
[FLINK-12] Clean up configuration object
- Remove class loader (was inconsistently used and set)
- Objects are stored in their type, rather than as a string
- casting happens on object (for numbers) with fallback to parsing of the
string representation
- global configuration reuses config object, rather than re-implementing
config logic.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 4f6f3f9c8cd9f2b43068180cc32288263219d00b
Author: Stephan Ewen <[email protected]>
Date: 2014-09-26T15:05:50Z
[FLINK-12] Clean up configuration object
- Remove class loader (was inconsistently used and set)
- Objects are stored in their type, rather than as a string
----
> [GitHub] Rework Configuration Objects
> -------------------------------------
>
> Key: FLINK-12
> URL: https://issues.apache.org/jira/browse/FLINK-12
> Project: Flink
> Issue Type: Improvement
> Reporter: GitHub Import
> Labels: github-import
> Fix For: pre-apache
>
>
> Currently, the configurations are implemented hacky. Everything is
> represented as a serialized string and there is no clean interface, such that
> different flavors of configurations (global-, delegatin-, default) are
> inconsistent.
> I propose to rework the configuration as a map of objects, which are
> serialized on demand with either a serialization library, or default
> serialization mechanisms. Factoring out the interface of a Configuration
> allows to keep all flavors consistent.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/12
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: enhancement,
> Created at: Mon Apr 29 23:43:11 CEST 2013
> State: open
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
