Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/141#discussion_r18446562
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java
---
@@ -139,7 +139,8 @@ public void setCombinable(boolean combinable) {
return po;
}
- else if (grouper.getKeys() instanceof Keys.FieldPositionKeys) {
+ else if (grouper.getKeys() instanceof Keys.ExpressionKeys) {
//was field position key
+ //TODO ask stephan
--- End diff --
Should get rid of this TODO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
