Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19733560
  
    --- Diff: 
flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
 ---
    @@ -108,14 +90,16 @@
     
        protected HBaseResult hbaseResult;
     
    -   private org.apache.hadoop.conf.Configuration hConf;
    +   private Configuration parameters;
     
    +// private org.apache.hadoop.conf.Configuration hConf;
    +   public TableInputFormat(Configuration parameters){
    +           this.parameters = parameters;
    +   }
    +   
        @Override
        public void configure(Configuration parameters) {
    -           HTable table = createTable(parameters);
    -           setTable(table);
    -           Scan scan = createScanner(parameters);
    -           setScan(scan);
    +           //TODO why parameters gets empty after execution??
    --- End diff --
    
    The ``TableInputFormat`` object is serialized and shipped to the JM and 
TMs. So all member variables of the ``TableInputFormat`` class are serialized 
and shipped as well (if not declared transient). This should also work for a 
``Configuration`` object. You set the ``Configuration`` as a member in the 
constructor, so this object should also be serialized and be available when 
``configure()``, ``open()``, or any other method is called. 
    
    Which ``Configuration`` object is empty, the member variable or the 
parameter passed to ``configure()``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to