Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19832577
  
    --- Diff: 
flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/common/HBaseResult.java
 ---
    @@ -21,10 +21,15 @@
     
     import java.io.IOException;
     
    +import org.apache.flink.api.java.typeutils.runtime.DataInputViewStream;
     import org.apache.flink.core.memory.DataInputView;
     import org.apache.flink.core.memory.DataOutputView;
    +import org.apache.flink.core.memory.DataOutputViewStream;
     import org.apache.flink.types.Value;
     import org.apache.hadoop.hbase.client.Result;
    +import org.apache.hadoop.hbase.mapreduce.ResultSerialization;
    +import org.apache.hadoop.io.serializer.Deserializer;
    +import org.apache.hadoop.io.serializer.Serializer;
     
     public class HBaseResult implements Value {
    --- End diff --
    
    Great! 
    For the TableOutputFormat, it might be better to have something like the 
JDBCOutputFormat or the CSVOutputFormat, i.e., it receives a Tuple data type 
and assigns the individual fields of the tuples to HBase keys and/or columns. 
However, I'm not familiar with HBase's API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to