[
https://issues.apache.org/jira/browse/FLINK-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198864#comment-14198864
]
Fabian Hueske commented on FLINK-1008:
--------------------------------------
Hi Stefan,
thanks for contributing and welcome to the Flink community!
I had a very brief look at your PR and didn't find any obvious problems with it.
In general, code review is one aspect of pull requests. So it is not really
necessary to do a pre-check. However, you should make sure, that your code
builds and does not break any tests by running ``mvn clean install`` locally or
use a build server like Travis CI. Also rebasing your changes to the lasted
master version is appreciated. The [coding
guidelines|http://flink.incubator.apache.org/coding_guidelines.html] list a few
more points.
Cheers, Fabian
> createProgramPlan() throws exception
> ------------------------------------
>
> Key: FLINK-1008
> URL: https://issues.apache.org/jira/browse/FLINK-1008
> Project: Flink
> Issue Type: Bug
> Components: Java API
> Reporter: Bastian Köcher
> Attachments: impro3-ss14-stratosphere.zip
>
>
> After calling createProgramPlan() I get the following exception:
> java.lang.RuntimeException: No data sinks have been created yet. A program
> needs at least one sink that consumes data. Examples are writing the data set
> or printing it.
> at
> eu.stratosphere.api.java.ExecutionEnvironment.createProgramPlan(ExecutionEnvironment.java:618)
> at
> eu.stratosphere.api.java.LocalEnvironment.execute(LocalEnvironment.java:51)
> at
> eu.stratosphere.api.java.ExecutionEnvironment.execute(ExecutionEnvironment.java:516)
> The plan execute and we also have data sinks, so the error is really
> confusing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
