[ 
https://issues.apache.org/jira/browse/FLINK-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204547#comment-14204547
 ] 

ASF GitHub Bot commented on FLINK-1219:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/189#discussion_r20072304
  
    --- Diff: 
flink-addons/flink-tez/src/main/java/org/apache/flink/tez/dag/FlinkVertex.java 
---
    @@ -0,0 +1,112 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.tez.dag;
    +
    +
    +import org.apache.flink.tez.runtime.TezTaskConfig;
    +import org.apache.tez.dag.api.TezConfiguration;
    +import org.apache.tez.dag.api.Vertex;
    +
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.UUID;
    +
    +public abstract class FlinkVertex {
    +
    +   protected Vertex cached;
    +   private String taskName;
    +   private int parallelism;
    +   protected TezTaskConfig taskConfig;
    +
    +   // Tez-specific bookkeeping
    +   protected String uniqueName; //Unique name in DAG
    +   private Map<FlinkVertex,ArrayList<Integer>> inputPositions;
    +   private ArrayList<Integer> numberOfSubTasksInOutputs;
    +
    +   public TezTaskConfig getConfig() {
    +           return taskConfig;
    +   }
    +
    +   public FlinkVertex(String taskName, int parallelism, TezTaskConfig 
taskConfig) {
    +           this.cached = null;
    +           this.taskName = taskName;
    +           this.parallelism = parallelism;
    +           this.taskConfig = taskConfig;
    +           this.uniqueName = taskName + UUID.randomUUID().toString();
    +           this.inputPositions = new HashMap<FlinkVertex, 
ArrayList<Integer>>();
    +           this.numberOfSubTasksInOutputs = new ArrayList<Integer>();
    +   }
    +
    +   public int getParallelism () {
    +           return parallelism;
    +   }
    +
    +   public void setParallelism (int parallelism) {this.parallelism = 
parallelism;}
    --- End diff --
    
    Inconsistent getter-setter style. I think putting the setter in one line is 
uncommon in our code.


> Add support for Apache Tez as execution engine
> ----------------------------------------------
>
>                 Key: FLINK-1219
>                 URL: https://issues.apache.org/jira/browse/FLINK-1219
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Kostas Tzoumas
>            Assignee: Kostas Tzoumas
>
> This is an umbrella issue to track Apache Tez support.
> The goal is to be able to run unmodified Flink programs as Apache Tez jobs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to