Github user dukechain commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/194#discussion_r20140135
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/JoinOperator.java
---
@@ -1215,8 +1735,7 @@ public JoinProjection(DataSet<I1> ds1, DataSet<I2>
ds2, Keys<I1> keys1, Keys<I2>
* Projects a pair of joined elements to a {@link Tuple} with
the previously selected fields.
* Requires the classes of the fields of the resulting tuples.
*
- * @param type0 The class of field '0' of the result tuples.
- * @param type1 The class of field '1' of the result tuples.
+ * @param type0 The class of field '0' of the result tuples.
@param type1 The class of field '1' of the result tuples.
--- End diff --
It seems "mvn verify" does not permit a .java file exceeds 2500 lines.
Anyway, these types() would not be used again if we drop types() in project().
I would remove them totally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
