Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/193#discussion_r20142322
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/AbstractFileIOChannel.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.disk.iomanager;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.RandomAccessFile;
+import java.nio.channels.FileChannel;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.base.Preconditions;
+
+public abstract class AbstractFileIOChannel implements FileIOChannel {
+
+ /** Logger object for channel and its subclasses */
+ protected static final Logger LOG =
LoggerFactory.getLogger(FileIOChannel.class);
+
+ /** The ID of the underlying channel. */
+ protected final FileIOChannel.ID id;
+
+ /** A file channel for NIO access to the file. */
+ protected final FileChannel fileChannel;
+
+
+ /**
+ * Creates a new channel to the path indicated by the given ID. The
channel hands IO requests to
+ * the given request queue to be processed.
+ *
+ * @param channelID The id describing the path of the file that the
channel accessed.
+ * @param writeEnabled Flag describing whether the channel should be
opened in read/write mode, rather
+ * than in read-only mode.
+ * @throws IOException Thrown, if the channel could no be opened.
+ */
+ protected AbstractFileIOChannel(FileIOChannel.ID channelID, boolean
writeEnabled) throws IOException {
+ Preconditions.checkNotNull(channelID);
+ this.id = channelID;
--- End diff --
trivial: we can do `this.id = checkNotNull(channelID);` directly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
