[
https://issues.apache.org/jira/browse/FLINK-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218284#comment-14218284
]
ASF GitHub Bot commented on FLINK-1252:
---------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/215#discussion_r20596015
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/EnumComparator.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.common.typeutils.base;
+
+import org.apache.flink.core.memory.DataInputView;
+import org.apache.flink.core.memory.MemorySegment;
+
+import java.io.IOException;
+
+
+public final class EnumComparator<T extends Enum<T>> extends
BasicTypeComparator<T> {
+
+ private static final long serialVersionUID = 1L;
+
+
+ public EnumComparator(boolean ascending) {
+ super(ascending);
+ }
+
+ @Override
+ public int compareSerialized(DataInputView firstSource, DataInputView
secondSource) throws IOException {
+ int i1 = firstSource.readInt();
+ int i2 = secondSource.readInt();
+ int comp = (i1 < i2 ? -1 : (i1 == i2 ? 0 : 1));
+ return ascendingComparison ? comp : -comp;
+ }
+
+
+ @Override
+ public boolean supportsNormalizedKey() {
+ return true;
+ }
+
+ @Override
+ public int getNormalizeKeyLen() {
+ return 4;
--- End diff --
Just curious, why is this 4 instead of 8?
> Add a serializer for Date
> -------------------------
>
> Key: FLINK-1252
> URL: https://issues.apache.org/jira/browse/FLINK-1252
> Project: Flink
> Issue Type: Improvement
> Reporter: Robert Metzger
> Assignee: Robert Metzger
>
> Since FLINK-610 is still an unresolved issue, I've started working on adding
> support for Date fields in POJOs in Flink.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
